AmqpSettings.IdleTimeout int to uint #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault with uint.MaxValue
optimuserik
commented
Dec 14, 2023
|
@microsoft-github-policy-service agree |
1 similar comment
|
@microsoft-github-policy-service agree |
|
@microsoft-github-policy-service rerun |
|
Unfortunately this is a breaking change which we are trying to avoid as much as possible. Let me check the feasibility of still using an int type but allowing negative values, with "-1" being the special case for infinite (no timeout). |
|
@optimuserik I made a change to allow using -1 for infinite idle timeout. Can you verify if that resolves the issue you observed? |
|
@xinchen10 It does solve the issue. Thank you :) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default AmqpSettings.IdleTimeout from int to uint.
Chenge the initialization from int.MaxValue to uint.MaxValue