Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: test case for health probe annotations #1117

Merged
merged 8 commits into from Feb 1, 2021

Conversation

3quanfeng
Copy link
Contributor

@3quanfeng 3quanfeng commented Jan 26, 2021

Checklist

  • The title of the PR is clear and informative
  • If applicable, the changes made in the PR have proper test coverage
  • Issues addressed by the PR are mentioned in the description followed by Fixes.

Description

E2E coverage on new health probe annotations including path, hostname, port, status codes

akshaysngupta
akshaysngupta previously approved these changes Jan 28, 2021
Copy link
Member

@akshaysngupta akshaysngupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3quanfeng
Copy link
Contributor Author

E2E Verification is PASS

@akshaysngupta akshaysngupta changed the title e2e test case for health probe annotations e2e: test case for health probe annotations Feb 1, 2021
Copy link
Member

@akshaysngupta akshaysngupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akshaysngupta akshaysngupta merged commit 7c479aa into master Feb 1, 2021
@akshaysngupta akshaysngupta deleted the biga/release1.4-e2e branch July 7, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants