Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: remove tag LastUpdatedByK8sIngress as this causes diff in generated config #1123

Merged
merged 3 commits into from Feb 3, 2021
Merged

config: remove tag LastUpdatedByK8sIngress as this causes diff in generated config #1123

merged 3 commits into from Feb 3, 2021

Conversation

akshaysngupta
Copy link
Member

@akshaysngupta akshaysngupta commented Feb 2, 2021 •
edited

This PR removes the LastUpdatedByK8sIngress as this causes unnecessary in AppGW config and leads to longer to operation times.

Checklist

  • The title of the PR is clear and informative
  • If applicable, the changes made in the PR have proper test coverage
  • Issues addressed by the PR are mentioned in the description followed by Fixes.

Description

Fixes

3quanfeng
3quanfeng approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@3quanfeng 3quanfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akshaysngupta akshaysngupta merged commit 16937d9 into master Feb 3, 2021
@akshaysngupta akshaysngupta deleted the aksgupta/removeTag branch July 7, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3quanfeng 3quanfeng 3quanfeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akshaysngupta @3quanfeng