Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow same port to used on both public and private ingresses #1539

Merged
merged 5 commits into from May 3, 2023
Merged

allow same port to used on both public and private ingresses #1539

merged 5 commits into from May 3, 2023

Conversation

akshaysngupta
Copy link
Member

@akshaysngupta akshaysngupta commented Apr 29, 2023 •
edited

Checklist

  • The title of the PR is clear and informative
  • If applicable, the changes made in the PR have proper test coverage
  • Issues addressed by the PR are mentioned in the description followed by Fixes.

Description

This PR removes restriction on using same port on both public and private ingresses.

Fixes

@akshaysngupta akshaysngupta changed the title allow same port to used on both public and private listener allow same port to used on both public and private ingresses Apr 29, 2023
alxyzc
alxyzc reviewed May 2, 2023
View reviewed changes
pkg/appgw/configbuilder.go Outdated Show resolved Hide resolved
@akshaysngupta akshaysngupta merged commit e26b8ee into master May 3, 2023
2 checks passed
@akshaysngupta akshaysngupta linked an issue May 3, 2023 that may be closed by this pull request
Can't assign port fp-443 to Private IP Listener already assigned to Public IP Listener #948
Closed
akshaysngupta added a commit that referenced this pull request May 24, 2023
@akshaysngupta
allow same port to used on both public and private ingresses (#1539)
d7d40da
@akshaysngupta akshaysngupta deleted the aksgupta/support-same-port branch September 5, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxyzc alxyzc alxyzc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't assign port fp-443 to Private IP Listener already assigned to Public IP Listener
2 participants
@akshaysngupta @alxyzc