upgrade k8s client-go to v0.16.7 #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
3quanfeng
commented
Apr 23, 2020
3quanfeng
commented
- bring k8s client-go up to v0.16.7 wo work with k8s 1.16.7
- update CRD client code to use the new signature introduced by new client-go, i.e. context
- update existing test cases to use the new signature
- golang version upgrade from 1.12 to 1.13
- some minor fix regarding go test with tag, i.e. -tags unittest
1. upgrade crd AzureApplicationGatewayBackendPool go client 2. upgrade crd AzureIngressProhibitedTarget go client 3. upgrade istio_crd_client
akshaysngupta
approved these changes
Apr 23, 2020
draychev
approved these changes
Apr 24, 2020
| @@ -1,59 +1,40 @@ | |||
| module github.com/Azure/application-gateway-kubernetes-ingress | |||
|
|
|||
| go 1.12 | |||
| go 1.13 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.