Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.EventGrid/topics/{topic}/providers/Microsoft.EventGrid/eventSubscriptions (2018-01-01) #18

Closed
SebastianSchuetze opened this issue Dec 6, 2019 · 4 comments
Assignees
Labels
defaults Noise caused by property default values fix committed The fix for the issue has been checked into an internal repo and is awaiting deployment noise Noise in what-if response read only Noise caused by read-only properties

Comments

@SebastianSchuetze
Copy link

SebastianSchuetze commented Dec 6, 2019

Describe the noise

Resource type (i.e. Microsoft.Storage/storageAccounts)
Microsoft.EventGrid/topics/{topic}/providers/Microsoft.EventGrid/eventSubscriptions

apiVersion (i.e. 2019-04-01)
2018-01-01

Client (PowerShell, Azure CLI, or API)
PowerShell

Relevant ARM Template code (we only need the resource object specified in 1 and 2, but if it's easier you can include the entire template

{
            "type": "Microsoft.EventGrid/topics",
            "apiVersion": "2018-01-01",
            "name": "[parameters('eventGridTopicName')]",
            "location": "[parameters('location')]"
        },
        {
            "type": "Microsoft.EventGrid/topics/providers/eventSubscriptions",
            "apiVersion": "2018-01-01",
            "name": "[concat(parameters('eventGridTopicName'), '/Microsoft.EventGrid/', parameters('eventGridSubscriptionName'))]",
            "location": "[parameters('location')]",
            "dependsOn": [
                "[parameters('eventGridTopicName')]"
            ],
            "properties": {
                "destination": {
                    "endpointType": "WebHook",
                    "properties": {
                        "endpointUrl": "[parameters('eventGridSubscriptionUrl')]"
                    }
                },
                "filter": {
                    "includedEventTypes": [
                        "All"
                    ]
                }
            }
        }

Expected response (i.e. "I expected no noise since the template has not been modified since the resources were deployed)
I expected no noise since the template has not been modified since the resources were deployed

Current (noisy) response (either include a screenshot of the what-if output, or copy/paste the text)
image

Additional context
Add any other context about the problem here.

I used the following template: https://github.com/Azure/azure-quickstart-templates/tree/master/101-event-grid

@majastrz majastrz added defaults Noise caused by property default values noise Noise in what-if response read only Noise caused by read-only properties labels Dec 12, 2019
@alex-frankel
Copy link
Contributor

@SebastianSchuetze - is properties.destination.properties.endpointUrl considered a secret?

@SebastianSchuetze
Copy link
Author

yes @alex-frankel .Because it contains the full URL with a key which I could call directly. Since it is a webhook (in this case to a logic app) anybody could use it to do something with my logic app (or any other resource that uses webhooks).

@majastrz majastrz added the fix in progress The fix for the issue is in progress label Jun 10, 2020
@majastrz
Copy link
Member

majastrz commented Jun 10, 2020

The fix for the issue with endpointBaseUrl and endpointUrl has been checked in to an internal repo and is awaiting deployment. [w25]

@majastrz majastrz added fix committed The fix for the issue has been checked into an internal repo and is awaiting deployment and removed fix in progress The fix for the issue is in progress labels Jun 10, 2020
@alex-frankel
Copy link
Contributor

This should be fully resolved. Please let us know if you still see any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defaults Noise caused by property default values fix committed The fix for the issue has been checked into an internal repo and is awaiting deployment noise Noise in what-if response read only Noise caused by read-only properties
Projects
None yet
Development

No branches or pull requests

4 participants