-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the union type document issue #4603
Merged
ArcturusZhang
merged 15 commits into
Azure:feature/v3
from
ArcturusZhang:fix-union-type-description
Apr 28, 2024
Merged
fix the union type document issue #4603
ArcturusZhang
merged 15 commits into
Azure:feature/v3
from
ArcturusZhang:fix-union-type-description
Apr 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcturusZhang
requested review from
m-nash,
lirenhe,
ArthurMa1978,
hallipr and
JoshLove-msft
as code owners
April 19, 2024 08:59
ArcturusZhang
changed the title
fix the union type issue
fix the union type document issue
Apr 22, 2024
6 tasks
lirenhe
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4508
Fixes #4509
Description
We construct a message in xml doc on a property when the its type is related with
BinaryData
, including when the type is BinaryData, or the type is a collection type ofBinaryData
.Previously the code was not written in a recursive way so that the generator only adds messages when the type is
IDictionary<string, BinaryData>
orIList<BinaryData>
. It does not recognize more complicated cases such asIDictionary<string, IList<BinaryData>>
, we are having this case in the additional properties cadl ranch cases.Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?