This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Generate unique names for synthesized schemas like ContentType #358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses an issue found by @ShivangiReja when using a newer version of the Form Recognizer spec. When the
always-create-content-type-parameter
option is used andimage/bmp
content type is added to only one of the 3 operations that accept image types, an additionalSealedChoiceSchema
with the nameContentType
is created, causing the "checker" phase to fail with a duplicate schema name. This is also possible when synthesizingAccept
headers.The fix is to ensure uniqueness of these generated header names by adding logic to increment a numeric suffix that gets applied when more than one schema with a particular name is created.