Update bearer to Bearer (#2576)

* Update the changes * Update the test cases * Update the transformation * Fix the smoke testing issue * Fix the smoke testing issue * Regen due to format issue
Azure · Jun 13, 2024 · ed17e14 · ed17e14
1 parent 365517e
commit ed17e14
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 6 deletions.
diff --git a/packages/rlc-common/src/buildClient.ts b/packages/rlc-common/src/buildClient.ts
@@ -391,7 +391,7 @@ export function getClientFactoryBody(
         client.pipeline.addPolicy({
           name: "customKeyCredentialPolicy",
           async sendRequest(request, next) {
-            request.headers.set("Authorization", "bearer " + credentials.key);
+            request.headers.set("Authorization", "Bearer " + credentials.key);
             return next(request);
           },
         });

diff --git a/packages/typespec-test/test/openai_generic/generated/typespec-ts/src/rest/openAIClient.ts b/packages/typespec-test/test/openai_generic/generated/typespec-ts/src/rest/openAIClient.ts
@@ -44,7 +44,7 @@ export default function createClient(
   client.pipeline.addPolicy({
     name: "customKeyCredentialPolicy",
     async sendRequest(request, next) {
-      request.headers.set("Authorization", "bearer " + credentials.key);
+      request.headers.set("Authorization", "Bearer " + credentials.key);
       return next(request);
     },
   });

diff --git a/...ages/typespec-test/test/openai_non_branded/generated/typespec-ts/src/rest/openAIClient.ts b/...ages/typespec-test/test/openai_non_branded/generated/typespec-ts/src/rest/openAIClient.ts
@@ -34,7 +34,7 @@ export default function createClient(
   client.pipeline.addPolicy({
     name: "customKeyCredentialPolicy",
     async sendRequest(request, next) {
-      request.headers.set("Authorization", "bearer " + credentials.key);
+      request.headers.set("Authorization", "Bearer " + credentials.key);
       return next(request);
     },
   });

diff --git a/packages/typespec-test/test/todo_non_branded/generated/typespec-ts/src/todoClient.ts b/packages/typespec-test/test/todo_non_branded/generated/typespec-ts/src/todoClient.ts
@@ -36,7 +36,7 @@ export default function createClient(
   client.pipeline.addPolicy({
     name: "customKeyCredentialPolicy",
     async sendRequest(request, next) {
-      request.headers.set("Authorization", "bearer " + credentials.key);
+      request.headers.set("Authorization", "Bearer " + credentials.key);
       return next(request);
     },
   });

diff --git a/packages/typespec-ts/src/transform/transfromRLCOptions.ts b/packages/typespec-ts/src/transform/transfromRLCOptions.ts
@@ -1,4 +1,5 @@
 import {
+  pascalCase,
   NameType,
   normalizeName,
   PackageDetails,
@@ -106,7 +107,13 @@ function processAuth(program: Program) {
         case "http":
           securityInfo.addCredentials = true;
           securityInfo.customHttpAuthHeaderName = "Authorization";
-          securityInfo.customHttpAuthSharedKeyPrefix = auth.scheme;
+          // If it is basic or bearer auth we should generate it as Basic or Bearer
+          securityInfo.customHttpAuthSharedKeyPrefix = [
+            "basic",
+            "bearer"
+          ].includes(auth.scheme.toLowerCase())
+            ? pascalCase(auth.scheme)
+            : auth.scheme;
           break;
         case "apiKey":
           if (auth.in === "cookie") {

diff --git a/packages/typespec-ts/test/unit/clientFactoryGenerator.spec.ts b/packages/typespec-ts/test/unit/clientFactoryGenerator.spec.ts
@@ -601,7 +601,7 @@ describe("Client Factory generation", () => {
           client.pipeline.addPolicy({
             name: "customKeyCredentialPolicy",
             async sendRequest(request, next) {
-              request.headers.set("Authorization", "bearer " + credentials.key);
+              request.headers.set("Authorization", "Bearer " + credentials.key);
               return next(request);
             },
           });