Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure-sdk-for-js] test folder structure - managing env.ts and env.browser.ts files #2533

Closed
HarshaNalluru opened this issue May 21, 2024 · 0 comments · Fixed by #2534
Closed

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented May 21, 2024

I've seen env.ts and env.browser.ts files in the generated test/ folders for the SDKs in azure-sdk-for-js.

Starting from recorder v2, we did not need env.ts and env.browser.ts files.

Currently, all the packages in azure-sdk-for-js depend on recorder v3 or v4

  • importing these files(env.ts) while using recorder v3 does not break anything. But it is recommended to remove them.
  • However, from recorder v4, importing these files(env.ts) will break the tests because of the switch from commonjs to esm.

TO DO

  • remove env.ts and env.browser.ts files
  • remove import "./env.js" or import "./env" or equivalent imports in test files
  • If the mapping for browser for these is put in package.json, remove that too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant