rename client class name for rlc #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaozha
requested review from
sarangan12,
joheredi and
JonathanCrd
as code owners
xirzec
reviewed
Mar 22, 2022
test/smoke/generated/purview-administration-rest/review/purview-administration-rest.api.md
Show resolved
Hide resolved
| @@ -884,6 +880,10 @@ export interface CascadeDeleteJobOutput { | |||
| status?: string; | |||
| } | |||
|
|
|||
| // @public (undocumented) | |||
| function createClient(Endpoint: string, options?: ClientOptions): AzureAgriFoodPlatformDataPlaneServiceClient; | |||
There was a problem hiding this comment.
I think we should only export this as the default export to leave for later adding a second client, what do you think @joheredi ?
There was a problem hiding this comment.
I think this only exports it as the default below, there is no access to createClient as a named import/export
There was a problem hiding this comment.
It would be nice if we could somehow make this clear in api-extractor or else api reviews are going to be misleading
joheredi
reviewed
Mar 22, 2022
test/smoke/generated/purview-administration-rest/review/purview-administration-rest.api.md
Outdated
Show resolved
Hide resolved
joheredi
approved these changes
Mar 22, 2022
joheredi
reviewed
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are adding a
Likesuffix for client class name, and keep the title name as client factory name.In this PR, we will add a
Clientsuffix for client class name, if it's not end withClient. and usecreateClientas the client factory name. and remove the default export of client factory name for multi-clients.