Fixes may #1836
Merged
Fixes may #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joheredi
commented
May 9, 2023
joheredi
commented
- Fix crash when generating OpenAI
- Fix misshandling of Nullable types
- Remove un-necessary synthetic parameters (content-type and accept)
- Fix the use of options
|
I have already resolved the merge conflicts in this PR joheredi#6 |
qiaozha
reviewed
May 18, 2023
packages/typespec-test/test/eventgrid_modular/generated/typespec-ts/src/rest/responses.ts
Show resolved
Hide resolved
qiaozha
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.