Integrate the cadl-ranch cases for encode and empty model cases #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryGao
changed the title
MaryGao
commented
Jun 2, 2023
| .path(`/encode/duration/header/iso8601-array`) | ||
| .get({ | ||
| headers: { | ||
| duration: ["P40D", "P50D"] as any |
There was a problem hiding this comment.
@qiaozha I notice that RawHttpHeadersInput only allows for string|number|boolean which means there would exist type inference conflict for this property.
It feels like as any is just a walkaround and would suggest to update the RawHttpHeadersInput header to allow some values like string[] or also build a helper function for the default csv format.
How do you think?
There was a problem hiding this comment.
Don't think we should change the RawHttpHeadersInput to add string[] type. let's add a helper for it.
There was a problem hiding this comment.
Sure I'll apply that change.
qiaozha
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate the cadl-ranch cases for:
@encodewith header and query