Fix collectionFormat issue in header #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryGao
commented
Jun 6, 2023
| @@ -304,4 +304,4 @@ function getAllOperations(model: CodeModel): Operation[] { | |||
| } | |||
|
|
|||
| return operations; | |||
| } | |||
| } | |||
There was a problem hiding this comment.
I didn't support this case in swagger side, because I didn't find a valid case anywhere and when I tried to build one the autorest would complain Unknown primitive schema array.
I guess only primitive types are supported in header for autorest.
MaryGao
commented
Jun 6, 2023
| @@ -1,9 +1,9 @@ | |||
| export const buildMultiCollectionContent = ` | |||
| export function buildMultiCollection( | |||
| queryParameters: string[], | |||
There was a problem hiding this comment.
Change the param name to item because it is not limited to query params.
qiaozha
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When touching the collectionFormat integration cases we generate string[] for header with format defined, but I notice that
RawHttpHeadersInputonly allows forstring|number|booleanwhich means there would exist type inference conflict for this property.https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/core/core-rest-pipeline/src/interfaces.ts#L12-L15
To fix that we need to build a helper function for the default csv format for header.