Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix credential issue in hlc #1956

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

MaryGao
Copy link
Contributor

@MaryGao MaryGao commented Aug 4, 2023

fixes #1724

  • Add default credential info if the addCredentials is set as true by customers
  • Add UT for readme generation in HLC

@MaryGao MaryGao changed the title Fix credential issue Fix credential issue in hlc Aug 4, 2023
let refinedAddCredentials =
addCredentials === false ? false : security.authenticationRequired;
// Add default info if explictly set the addCredentials as true
if (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the default value as token credential with scope https://management.azure.com/.default.

@MaryGao MaryGao requested a review from qiaozha August 30, 2023 04:39
@MaryGao MaryGao merged commit c138441 into Azure:main Aug 30, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid client constructor generated.
2 participants