fix-get-parent-properties #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaozha
requested review from
sarangan12,
joheredi and
MaryGao
as code owners
MaryGao
reviewed
Sep 13, 2023
MaryGao
reviewed
Sep 13, 2023
MaryGao
reviewed
Sep 14, 2023
| @@ -943,3 +943,15 @@ export function hasPagingOperation(codeModel: ModularCodeModel) { | |||
| ) | |||
| ); | |||
| } | |||
|
|
|||
| function getAllProperties(type: Type): Property[] { | |||
| const properties: Property[] = []; | |||
There was a problem hiding this comment.
nit: not sure this is caused the duplicated properties issues when discriminator property exists both parent and child model. see below cadl-ranch cases:
There was a problem hiding this comment.
Yeah, I found that, when I was trying to enable cadl ranch test cases for model inheritance in modular.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2014