Upgrade to ts http runtime #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lirenhe
reviewed
Nov 7, 2023
packages/autorest.typescript/src/restLevelClient/transforms/transform.ts
Outdated
Show resolved
Hide resolved
lirenhe
reviewed
Nov 7, 2023
lirenhe
reviewed
Nov 7, 2023
...ges/typespec-ts/test/nonBrandedIntegration/modular/generated/models/usage/src/UsageClient.ts
Outdated
Show resolved
Hide resolved
lirenhe
reviewed
Nov 7, 2023
packages/typespec-ts/test/nonBrandedIntegration/modular/generated/models/usage/tspconfig.yaml
Show resolved
Hide resolved
lirenhe
reviewed
Nov 7, 2023
packages/typespec-test/test/openai_non_branded/generated/typespec-ts/package.json
Outdated
Show resolved
Hide resolved
joheredi
reviewed
Nov 7, 2023
joheredi
reviewed
Nov 7, 2023
joheredi
reviewed
Nov 7, 2023
| @@ -11,6 +11,7 @@ import { Client, ModularCodeModel, Operation } from "./modularCodeModel.js"; | |||
| import { isRLCMultiEndpoint } from "../utils/clientUtils.js"; | |||
| import { getDocsFromDescription } from "./helpers/docsHelpers.js"; | |||
| import { SdkContext } from "../utils/interfaces.js"; | |||
| import { getImportSpecifier } from "@azure-tools/rlc-common"; | |||
There was a problem hiding this comment.
It strikes me as odd to see an rlc-common import in the modular codegen layer. Probably okay but wanted to bring this up in case there is an alternative
There was a problem hiding this comment.
Currently the rlc-common utils are widely used in modular lib e.g naming utils or rlc operation utils.
joheredi
reviewed
Nov 7, 2023
joheredi
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2081
brandedand allow to generate the non-branded SDK