Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade version for test-recorder and test-credential && support RECORDINGS_RELATIVE_PATH in vitest.browser.config.ts #2528

Merged
merged 7 commits into from
Jun 13, 2024

Conversation

kazrael2119
Copy link
Contributor

@kazrael2119 kazrael2119 commented May 20, 2024

fixes #2524
fixes #2448
fixes #2354

@kazrael2119 kazrael2119 marked this pull request as ready for review May 23, 2024 02:49
@qiaozha qiaozha changed the title upgrade version for esm upgrade version for test recorder May 23, 2024
@kazrael2119 kazrael2119 changed the title upgrade version for test recorder upgrade version for test-recorder and test-credential May 23, 2024
@kazrael2119 kazrael2119 changed the title upgrade version for test-recorder and test-credential upgrade version for test-recorder and test-credential && support RECORDINGS_RELATIVE_PATH in vitest.browser.config.ts May 23, 2024
Copy link
Contributor

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try all these fixes in network.analytis pr in sdk repo?

@MaryGao MaryGao self-requested a review June 13, 2024 08:57
@MaryGao
Copy link
Contributor

MaryGao commented Jun 13, 2024

Could you try all these fixes in network.analytis pr in sdk repo?

verified here: Azure/azure-sdk-for-js#29770

Copy link
Contributor

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryGao MaryGao merged commit 43d8054 into Azure:main Jun 13, 2024
14 checks passed
@kazrael2119 kazrael2119 deleted the upgrade-version-for-esm branch June 14, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants