Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treat-unknown-as-any-in-modular #2546

Merged
merged 6 commits into from
May 27, 2024
Merged

treat-unknown-as-any-in-modular #2546

merged 6 commits into from
May 27, 2024

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented May 23, 2024

fixes #2078

@qiaozha qiaozha marked this pull request as ready for review May 24, 2024 06:51
lirenhe
lirenhe approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@lirenhe lirenhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As this would introduce public API change, please ensure we also get signoff from Redmond team.

MaryGao
MaryGao approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiaozha
Copy link
Member Author

qiaozha commented May 27, 2024

Offline confirmed with @joheredi, this looks good to go :)

@qiaozha qiaozha merged commit 778140a into Azure:main May 27, 2024
14 checks passed
@qiaozha qiaozha deleted the treat-unknown-as-any-in-modular branch May 27, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirenhe lirenhe lirenhe approved these changes

@MaryGao MaryGao MaryGao approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discuss how TypeSpec unknown is generated in DPG
4 participants
@qiaozha @lirenhe @MaryGao @v-jiaodi