Add shell=true when spawning cmd files in windows

Azure · May 21, 2024 · 4c9c644 · 4c9c644
1 parent 1f91e16
commit 4c9c644
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/eng/scripts/helpers.js b/eng/scripts/helpers.js
@@ -21,6 +21,9 @@ function run(command, args, options) {
 
   if (process.platform === "win32" && isCmdOnWindows.includes(command)) {
     command += ".cmd";
+    // When spawning .bat or .cmd files on windows, node will now error with EINVAL if shell is not set to true.
+    // https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2
+    options.shell = true;
   }
 
   const proc = (options.sync ? spawnSync : spawn)(command, args, options);