Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAF compliancy patch for ZRS #603

Merged
merged 37 commits into from
Apr 12, 2024
Merged

Conversation

yahanda
Copy link
Contributor

@yahanda yahanda commented Apr 4, 2024

Overview/Summary

Update default storage account type option to be completely WAF compliant as per ADO Items below:
https://dev.azure.com/CSUSolEng/Accelerator%20-%20AVD/_workitems/edit/32716/

This PR fixes/adds/changes/removes

  1. The option to select "Zone redundant storage" for storage account is disabled by default. Zone redundant storage is supported for both Standard and premium storage.

Breaking Changes

  1. Replace me
  2. Replace me

Testing Evidence

Added Storage API check to verify if ZRS can be used in the region.

  • If ZRS is available, two options are given and ZRS is the default.
    image

  • If ZRS is not available, LRS is the only option.
    image

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

@danycontre
Copy link
Collaborator

@yahanda thanks for your contribution.

@danycontre danycontre merged commit 4e93ef8 into Azure:main Apr 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants