Bug/13 download terraform loop #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cedrox Thank you for looking into this and finding the root cause 👍. I've made another commit on top of yours, which both doing some cleanup to remove the debug related stuff (to make the code cleaner and the PR more focus on the issue), and used another way to differentiate between windows and non-windows by using Go build constraint (see: https://pkg.go.dev/cmd/go#hdr-Build_constraints for details). |
|
Much cleaner ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://github.com/magodo/aztfy/issues/13
tfinstall.ExecPathFinder need to have ExactPath.
On Windows it download terraform each time because the string compare is done on terraform and not terraform.exe