New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated the readme based on my testing #21

Merged

magodo merged 2 commits into Azure:main from simone-bennett:main

Oct 21, 2021

Contributor

simone-bennett commented Oct 20, 2021

Added in some windows install details for ppl like me :)

Simone Bennett and others added 2 commits

October 20, 2021 11:58


          updated the readme based on my testing

4b6692e


          remove some too-detailed steps (as that might be different per indivi…

a443292

…dual)

Collaborator

magodo commented Oct 20, 2021

@simone-bennett Thank you for submitting this 👍 This PR fixes some incorrect description of the usage, which applied to the old UI.

I've went through the changes and made another commit on top of your branch. The main changes include:

Remove some too detailed steps which tend to be different between individuals
Remove some already pointed out information (e.g. the prerequisites that to create a service principal is already mentioned in the link in the Usage section)

Please take a look at my changes and see whether that's fine to you. If that's OK, then I'll merge it.

magodo merged commit 6c00259 into Azure:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment