Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-ARM template export step for fixing some known ARM template issues #91

Merged
merged 3 commits into from
May 16, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented May 13, 2022

This PR adds an additional step after getting the exported ARM template, to mitigate the issue that ARM template doesn't list some resource that is marked as managedBy other resource. Especially, we add a such case for managed disk when attatched to a VM, to fix #77.

Copy link
Contributor

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍰

@magodo magodo merged commit 4d9f5e6 into Azure:main May 16, 2022
@magodo magodo deleted the postlisthook branch May 16, 2022 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to import Managed Disk
2 participants