Add clang builds for embedded TLS adapters #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… point dockes include clang too
ericwolz
approved these changes
Nov 19, 2021
danewalton
approved these changes
Nov 19, 2021
| @@ -253,6 +253,10 @@ jobs: | |||
| name: 'sdk-c--ubuntu-18' | |||
| displayName: 'linux_mbed' | |||
| steps: | |||
| - script: | | |||
There was a problem hiding this comment.
go up to the _PREVIEW_VSTS_DOCKER_IMAGE variable and make it aziotbld/linux-c-ubuntu-mbed
| @@ -287,6 +291,10 @@ jobs: | |||
| name: 'sdk-c--ubuntu-18' | |||
| displayName: 'wolfssl' | |||
| steps: | |||
| - script: | | |||
There was a problem hiding this comment.
this one aziotbld/linux-c-ubuntu-wolfssl
| @@ -327,6 +335,10 @@ jobs: | |||
| name: 'sdk-c--ubuntu-18' | |||
| displayName: 'bearssl' | |||
| steps: | |||
| - script: | | |||
There was a problem hiding this comment.
and this one aziotbld/linux-c-ubuntu-bearssl
ericwolz
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our TLS stacks that are primarily used on embedded or low-end Linux devices - wolfssl, bear, and mbed - are currently compiled and tested against gcc only. This is generally fine as gcc is the most common embedded compiler.
However... gcc misses certain warnings condition, especially around uninitialized variables. (See StackOverflow discussion here - I was easily able to reproduce this on gcc even with -Wall and any optimization setting I tried.)
clang does not miss this class of errors. So add a clang build to these stacks. This build only checks compilation step and does not rerun tests gcc currently handles.