{CI} azdev style: Use azdev config files when .flake8 and pylintrc are not found in azure cli/ext repo.
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllyW
approved these changes
Apr 2, 2024
|
@wangzelin007 this is how we are checking out the repo - git clone --single-branch -b dev https://github.com/Azure/azure-cli.git ../azure-cli |
kairu-ms
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the error message
The config file /__w/1/s/pylintrc doesn't exist!azdev can find the cli/ext repo(__w/1/s), but cannot find the pylintrc file in the repo.
We must know that pylintrc existed as early as 2016:
https://github.com/Azure/azure-cli/blob/dev/pylintrc
https://github.com/Azure/azure-cli-extensions/blob/main/pylintrc
Could it be that the code in the repo in these users' CI is very old, or user have manually deleted pylintrc, or user have checked out a branch that does not have pylintrc?
I can't understand why this happens.
The cli and extension repo have been found, but the pylintrc file is not found.
@irvokopo @hvedati
I'd be very grateful if you could provide some information.