Skip to content

Commit

Permalink
connectedk8s upgrade cmd bug fix (#5411)
Browse files Browse the repository at this point in the history
* Add security context to diagnoser container

* version and history updates

* fix proxy bug in connectedk8s upgrade

* removed diagnoser change

* removed extra space

Co-authored-by: Siri Teja Reddy Kasireddy <sikasire@microsoft.com>
Co-authored-by: Akash Keshari <akkeshar@microsoft.com>
Co-authored-by: siriteja <32883500+sirireddy12@users.noreply.github.com>
  • Loading branch information
4 people committed Oct 3, 2022
1 parent 54395df commit 901b97c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions src/connectedk8s/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
Release History
===============
1.3.4
++++++

* Fixed a proxy related bug in connectedk8s upgrade

1.3.3
++++++

Expand Down
1 change: 1 addition & 0 deletions src/connectedk8s/azext_connectedk8s/custom.py
Original file line number Diff line number Diff line change
Expand Up @@ -1232,6 +1232,7 @@ def upgrade_agents(cmd, client, resource_group_name, cluster_name, kube_config=N
if key == "global.isProxyEnabled":
proxy_enabled_param_added = True
if (key == "global.httpProxy" or key == "global.httpsProxy" or key == "global.noProxy"):
value = escape_proxy_settings(value)
if value and not proxy_enabled_param_added:
cmd_helm_upgrade.extend(["--set", "global.isProxyEnabled={}".format(True)])
proxy_enabled_param_added = True
Expand Down
2 changes: 1 addition & 1 deletion src/connectedk8s/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# TODO: Confirm this is the right version number you want and it matches your
# HISTORY.rst entry.

VERSION = '1.3.3'
VERSION = '1.3.4'

# The full list of classifiers is available at
# https://pypi.python.org/pypi?%3Aaction=list_classifiers
Expand Down

0 comments on commit 901b97c

Please sign in to comment.