-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --enable-azure-rbac flag in ManagedClusterAadProfile (#2) #1887
Conversation
@weinong can you review the PR? |
AKS |
Seems that 2020-06-01 has not yet been published. https://msazure.visualstudio.com/CloudNativeCompute/_git/manifests?path=%2Frp%2Fglobal.json&version=GBmaster&line=2067&lineEnd=2068&lineStartColumn=1&lineEndColumn=25&lineStyle=plain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
bca3370
to
0a693bf
Compare
Hi @bingosummer , could you please help resolve the merge conflict ? |
...preview/azext_aks_preview/vendored_sdks/azure_mgmt_preview_aks/v2020_06_01/models/_models.py
Outdated
Show resolved
Hide resolved
...w/tests/latest/recordings/test_aks_create_and_update_with_managed_aad_enable_azure_rbac.yaml
Outdated
Show resolved
Hide resolved
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
96bcebc
to
e514af5
Compare
@Anumita are we close to have this merged? Help needed? |
Hey, the builds are failing due to some tests failing for all pr right now. I have contacted the poc for the tests. Once that is fixed , i think the pr needs to be approved by gtracer or zquingqing1 and then can be merged. |
status: | ||
code: 200 | ||
message: OK | ||
code: 400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "bad request" expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure, i ran the tests again just to be sure, but getting the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.