Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Fix compatibility issue when enabling Microsoft Defender via aks-preview #5106

Merged
merged 6 commits into from
Jul 13, 2022

Conversation

FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Jul 12, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Fixed the model compatibility issue caused by the recent rebranding of Microsoft Defender when updating defender-related configurations through aks create/update commands in aks-preview. Would release a new version (0.5.91) of aks-preview.

Notice
The breaking change on this model is in effect in the preview API (corresponding to aks-preview) since 2022-05-02-preview.

In stable API (corresponding to azure-cli, without the extension aks-preview), the breaking change on this model will take effect from 2022-06-01

Fix issue #5090, #5092.

Related command

  • az aks create
  • az aks update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 July 12, 2022 02:43
@ghost ghost assigned zhoxing-ms Jul 12, 2022
@ghost ghost added this to the Jul 2022 (2022-08-02) milestone Jul 12, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Jul 12, 2022
@ghost ghost requested a review from yonzhan July 12, 2022 02:43
@ghost ghost added the AKS label Jul 12, 2022
@FumingZhang
Copy link
Member Author

FumingZhang commented Jul 12, 2022

Queued a pipeline to test newly added test cases. All passed.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 12, 2022

AKS

@FumingZhang FumingZhang marked this pull request as ready for review July 12, 2022 04:18
@zhoxing-ms zhoxing-ms merged commit fc3a348 into Azure:main Jul 13, 2022
@FumingZhang FumingZhang deleted the fuming/fix-defender-0711 branch July 19, 2022 05:28
@navba-MSFT navba-MSFT added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot bug This issue requires a change to an existing behavior in the product in order to be resolved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants