Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect URL #5970

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Fix incorrect URL #5970

merged 1 commit into from
Mar 15, 2023

Conversation

fabienmazieres
Copy link
Contributor

@fabienmazieres fabienmazieres commented Mar 10, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az serial-console

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 10, 2023
@ghost
Copy link

ghost commented Mar 10, 2023

Thank you for your contribution fabienmazieres! We will review the pull request and get back to you soon.

@ghost ghost requested a review from kairu-ms March 10, 2023 13:01
@ghost ghost added the Auto-Assign Auto assign by bot label Mar 10, 2023
@ghost ghost assigned kairu-ms Mar 10, 2023
@ghost ghost added this to the March 2023 (2023-04-04) milestone Mar 10, 2023
@ghost ghost added the Serial Console label Mar 10, 2023
@fabienmazieres
Copy link
Contributor Author

this is related to issue MicrosoftDocs/azure-docs-cli#3557

@fabienmazieres fabienmazieres marked this pull request as ready for review March 10, 2023 13:12
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 11, 2023

serial-console

@yonzhan yonzhan requested a review from jsntcy March 11, 2023 00:50
@kairu-ms
Copy link
Contributor

kairu-ms commented Mar 13, 2023

If you want to release, please update the version as well.

@kairu-ms kairu-ms merged commit 30c3bd4 into Azure:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization. Serial Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants