Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace network sdk for spring #5971

Merged
merged 5 commits into from
Mar 14, 2023
Merged

replace network sdk for spring #5971

merged 5 commits into from
Mar 14, 2023

Conversation

AllyW
Copy link
Member

@AllyW AllyW commented Mar 10, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az spring create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@ghost ghost requested review from yonzhan, jsntcy and kairu-ms March 10, 2023 14:19
@ghost ghost added the Auto-Assign Auto assign by bot label Mar 10, 2023
@ghost ghost requested a review from necusjz March 10, 2023 14:19
@ghost ghost assigned necusjz Mar 10, 2023
@ghost ghost added this to the March 2023 (2023-04-04) milestone Mar 10, 2023
@ghost ghost added the Network label Mar 10, 2023
@AllyW AllyW assigned AllyW and unassigned necusjz Mar 10, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 11, 2023

network upgrade

@AllyW AllyW merged commit 6dbe8e0 into Azure:main Mar 14, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=41259&view=results

from azure.cli.core.aaz import has_value
args = self.ctx.args
if has_value(args.subscription_id):
self.ctx._subscription_id = args.subscription_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.ctx._subscription_id = args.subscription_id.to_serialized_data()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants