Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} az aks create: Correct help message for option --os-sku #5977

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

For the system nodepool created when creating the AKS cluster, it must be a linux nodepool. Could add a windows nodepool after the cluster is created via az aks nodepool add. See doc Create a Windows Server container on an AKS cluster by using Azure CLI - Azure Kubernetes Service | Microsoft Learn.

Related command

az aks create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and yanzhudd March 13, 2023 02:47
@ghost ghost assigned zhoxing-ms Mar 13, 2023
@ghost ghost added this to the March 2023 (2023-04-04) milestone Mar 13, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label Mar 13, 2023
@ghost ghost requested a review from yonzhan March 13, 2023 02:48
@ghost ghost added the AKS label Mar 13, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 13, 2023

AKS

@FumingZhang FumingZhang marked this pull request as ready for review March 13, 2023 03:21
@zhoxing-ms zhoxing-ms merged commit 543e8df into Azure:main Mar 13, 2023
@FumingZhang FumingZhang deleted the fuming/fix-windows-sku-0313 branch April 10, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants