Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serial-Console] Fix pair mapping region for eastus to westus #6231

Merged
merged 12 commits into from
Jun 1, 2023

Conversation

rhkodiak
Copy link
Contributor

@rhkodiak rhkodiak commented Apr 21, 2023

The changes in the pull request are to address a problem found in the azure cli serial-console extension where an error was being thrown for eastus connections because there wasn't a pair region mapping for westus. The code changes add the eastus to westus region mappings to fix this issue.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az serial-console connect -g MyResourceGroup -n MyVmName

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @rhkodiak,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Apr 21, 2023
@ghost
Copy link

ghost commented Apr 21, 2023

Thank you for your contribution rhkodiak! We will review the pull request and get back to you soon.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 21, 2023

Serial-Console

@ghost ghost requested a review from kairu-ms April 21, 2023 19:59
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 21, 2023
@ghost ghost assigned kairu-ms Apr 21, 2023
@ghost ghost added the Serial Console label Apr 21, 2023
@yonzhan yonzhan requested a review from jsntcy April 21, 2023 22:02
@msftvito
Copy link

msftvito commented May 4, 2023

Can this be looked at?

@yonzhan
Copy link
Collaborator

yonzhan commented May 4, 2023

Please fix CI issues first.

@msftvito
Copy link

msftvito commented May 5, 2023

@rhkodiak there's other changes mixed in with the one for my issue. Can you resolve the issues so the PR goes through?

@kairu-ms
Copy link
Contributor

kairu-ms commented May 5, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kairu-ms kairu-ms changed the title [Serial-Console]: Fix pair mapping region for eastus to westus [Serial-Console] Fix pair mapping region for eastus to westus May 5, 2023
@kairu-ms
Copy link
Contributor

kairu-ms commented May 5, 2023

Hi @rhkodiak You may need to record the failed tests again.

@msftvito
Copy link

@rhkodiak are you able to resolve the failing tests?

@rhkodiak
Copy link
Contributor Author

rhkodiak commented May 16, 2023

@rhkodiak are you able to resolve the failing tests?

@msftvito - Yes, I will resolve this today.

@msftvito
Copy link

@rhkodiak it seems like the last build also had some errors? https://github.com/Azure/azure-cli-extensions/pull/6231/checks?check_run_id=13531660777

@rhkodiak
Copy link
Contributor Author

rhkodiak commented May 25, 2023

@rhkodiak it seems like the last build also had some errors? https://github.com/Azure/azure-cli-extensions/pull/6231/checks?check_run_id=13531660777

@msftvito - when I run the "azdev test serial-console --live" command to record the new test results the command completes successfully for me. I look at the build log where the failure occurs but I don't see why it fails here and not when I locally run the live tests. Can you run the command and see if you get the same results?

image

@kairu-ms
Copy link
Contributor

Hi @rhkodiak, according to the CI result, it seems the azure-mgmt-resource sdk is not the latest in your Local machine. Please pull the latest change of dev branch of azure-cli repo and run azdev setup again to update the sdks. After that you can record the tests again.

@rhkodiak
Copy link
Contributor Author

Hi @rhkodiak, according to the CI result, it seems the azure-mgmt-resource sdk is not the latest in your Local machine. Please pull the latest change of dev branch of azure-cli repo and run azdev setup again to update the sdks. After that you can record the tests again.

Hi @kairu-ms, I ran the instructions you provided and everything looks good now so ready for you to review. Thanks for the help!

@kairu-ms kairu-ms merged commit eacae60 into Azure:main Jun 1, 2023
13 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jun 1, 2023

[Release] Update index.json for extension [ serial-console ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=59480&view=results

@msftvito
Copy link

msftvito commented Jun 1, 2023

Thank you everyone for getting this merged in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization. Serial Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants