Azure Event Grid 0.4.1

[ahamad-MS]

---

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

• Have you run ./scripts/ci/test_static.sh locally? (pip install pylint flake8 required)
• Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

[azuresdkci]

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/ahamad-MS/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

[kalyanaj]

Nit: Consider changing "the destination endpoint to be created" to "the destination endpoint be created"

[ahamad-MS]

done

[tjprescott]

There's a lot of needless repetition in the params.py file. Review this link and ping me if you have questions.
https://github.com/Azure/azure-cli/blob/dev/doc/authoring_command_modules/authoring_commands.md#customize-arguments

[tjprescott]

Instead of repeating this code three times, just use a scope of eventgrid domain, which will apply it to all commands and subgroups under the domain subgroup.

[ahamad-MS]

Per our discussion, we needed to do this for domain to allow us to use different arguments and related names in domain topic scope. In specific, using --name for domain-topic-name (rather than domain-name which is used at domain scope) and domain-name for specifying the domain name (which is --name is domain scope).

[tjprescott]

So a couple techniques to reduce the duplication:

domain_name_type = CLIArgumentType(help='Name of the domain.', options_list='--domain-name', completer=get_resource_name_completion_list('Microsoft.EventGrid/domains'))

with self.argument_context('eventgrid domain') as c:
  c.argument('domain_name', domain_name_type, options_list=['--name', '-n'], id_part=name)

with self.argument_context('eventgrid domain topic') as c:
  c.argument('domain_name', domain_name_type, id_part=None)

And if you really needed to override per command (which is usually not the case):

for scope in ['create', 'update', 'delete']:
   with self.argument_context('eventgrid domain {}'.format(scope)) as c:
      c.argument('domain_name', …)

[ahamad-MS]

Thx for the suggestion. Makes sense. Fixed.