Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting default vm size for windows #637

Merged
merged 1 commit into from
Apr 17, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/aks-preview/azext_aks_preview/custom.py
Original file line number Diff line number Diff line change
Expand Up @@ -1005,7 +1005,7 @@ def aks_agentpool_list(cmd, client, resource_group_name, cluster_name):
def aks_agentpool_add(cmd, client, resource_group_name, cluster_name, nodepool_name,
kubernetes_version=None,
node_zones=None,
node_vm_size="Standard_DS2_v2",
node_vm_size=None,
node_osdisk_size=0,
node_count=3,
vnet_subnet_id=None,
Expand All @@ -1018,6 +1018,12 @@ def aks_agentpool_add(cmd, client, resource_group_name, cluster_name, nodepool_n
raise CLIError("Node pool {} already exists, please try a different name, "
"use 'aks nodepool list' to get current list of node pool".format(nodepool_name))

if node_vm_size is None:
if os_type == "Windows":
node_vm_size = "Standard_D2s_v3"
else:
node_vm_size = "Standard_DS2_v2"

agent_pool = AgentPool(
name=nodepool_name,
count=int(node_count),
Expand Down