Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosmosdb-preview] Add support for Priority Based Execution, cross account container copy, api-version 2023-09-15-preview #6703

Merged
merged 44 commits into from
Oct 13, 2023

Conversation

Achint-Agrawal
Copy link
Contributor

@Achint-Agrawal Achint-Agrawal commented Aug 29, 2023

This PR contains changes for 20230915-preview RP API release. This includes changes for Priority Based Execution, DTS and CMK.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 29, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️cosmosdb-preview
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd cosmosdb copy sub group cosmosdb copy added
⚠️ 1006 - ParaAdd cosmosdb create cmd cosmosdb create added parameter default_priority_level
⚠️ 1006 - ParaAdd cosmosdb create cmd cosmosdb create added parameter enable_priority_based_execution
⚠️ 1006 - ParaAdd cosmosdb update cmd cosmosdb update added parameter default_priority_level
⚠️ 1006 - ParaAdd cosmosdb update cmd cosmosdb update added parameter enable_priority_based_execution
⚠️ 1006 - ParaAdd managed-cassandra cluster create cmd managed-cassandra cluster create added parameter cluster_type
⚠️ 1006 - ParaAdd managed-cassandra cluster create cmd managed-cassandra cluster create added parameter extensions
⚠️ 1001 - CmdAdd managed-cassandra cluster deallocate cmd managed-cassandra cluster deallocate added
⚠️ 1006 - ParaAdd managed-cassandra cluster update cmd managed-cassandra cluster update added parameter cluster_type
⚠️ 1006 - ParaAdd managed-cassandra cluster update cmd managed-cassandra cluster update added parameter extensions

@azure-client-tools-bot-prd
Copy link

Hi @Achint-Agrawal,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link

Hi @Achint-Agrawal,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 29, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@Achint-Agrawal Achint-Agrawal changed the title rpapi20230915 preview 20230915 preview Aug 29, 2023
@pjohari-ms
Copy link
Member

@niteshvijay1995 Can you take a look at the breaking changes mentioned above?

@pjohari-ms
Copy link
Member

@Achint-Agrawal can you update these files as requested?

If you want to release a new version, don't forget to update the version in setup.py and history.rst

@Achint-Agrawal
Copy link
Contributor Author

If you want to release a new version, don't forget to update the version in setup.py and history.rst

@Achint-Agrawal can you update these files as requested?

If you want to release a new version, don't forget to update the version in setup.py and history.rst

Done. Thanks

@calvinhzy calvinhzy changed the title [cosmosdb-preview] 20230915 preview [cosmosdb-preview] Add support for Priority Based Execution, DTS and CMK, api-version 2023-09-15-preview Oct 11, 2023
@calvinhzy calvinhzy changed the title [cosmosdb-preview] Add support for Priority Based Execution, DTS and CMK, api-version 2023-09-15-preview [cosmosdb-preview] Add support for Priority Based Execution, cross account container copy, api-version 2023-09-15-preview Oct 11, 2023
@pjohari-ms
Copy link
Member

@evelyn-ys If this looks good, can we merge it?

@evelyn-ys evelyn-ys merged commit 6bfcf79 into Azure:main Oct 13, 2023
14 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ cosmosdb-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=96495&view=results

bgashirabake pushed a commit to bgashirabake/azure-cli-extensions that referenced this pull request Oct 16, 2023
…count container copy, api-version 2023-09-15-preview (Azure#6703)

* init changes for 20230915-preview api

* Changes to add enablePriorityBasedExecution and defaultPriorityLevel

* Removed isPreview flag from CMK related properties and added key-uri to cosmosdb update operation.

* Added test and test recording for priority based execution

* corrected resource group name and whitespace corrections

* white space corrections

* Add cosmosdb copy command

* Add tests

* Dts/cross account copy (Azure#3)

* Deprecate old command

* Add test recording for dts

---------

Co-authored-by: Nitesh Vijay <niteshvijay@microsoft.com>

* Fix build error

* Fix Static Analysis

* Use boolean type

* Change help text

* Update help text

* Updated Vendored SDK

* Updated test account name in test_cosmosdb-merge-scenario.py

* Whitespace correction and added linter exclution for enable pbe

* Updated linter_exclusions

* Remove id part

* Corrected account name in test_cosmosdb-merge-scenario.py and generated test recordings

* Generated test recording for test_cosmosdb_materializedview

* Add support for MI Cassandra in 2023-09-15

* Add -n for jobname

* Fix breaking change

* Modified setup.py and history.rst

* Fix static check

* Whitespace correction

* Re-recorded tests

* rerecorded test test_cosmosdb_sql_materializedview_scenario

* removed linter exclusion for enable_priority_based_execution

* Rerecorded all tests

* Updated HISTORY.rst

* Rerecorded tests

* rerecorded test_cosmosdb_sql_materializedview_scenario

* rerecorded test_cosmosdb_sql_materializedview_scenario

* rerecorded tests

---------

Co-authored-by: Achint Agrawal <acagrawal@microsoft.com>
Co-authored-by: AdrianSibajaRetana <54075415+AdrianSibajaRetana@users.noreply.github.com>
Co-authored-by: Nitesh Vijay <niteshvijay@microsoft.com>
Co-authored-by: Nitesh Vijay <niteshvijay1995@gmail.com>
Co-authored-by: Guanzhou <guanzhousong@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants