Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vm repair #6864

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Vm repair #6864

merged 5 commits into from
Oct 25, 2023

Conversation

qwuae1
Copy link
Contributor

@qwuae1 qwuae1 commented Oct 17, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

# SUSE Linux Enterprise Server 15 SP3
# SUSE Linux Enterprise Server 12 SP5
remove the SUSE image check
and use the image above
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 17, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @qwuae1,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 17, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@qwuae1 qwuae1 closed this Oct 18, 2023
@qwuae1 qwuae1 reopened this Oct 18, 2023
@zhoxing-ms
Copy link
Contributor

Please take a look at this comment~ #6864 (comment)

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Oct 19, 2023

@haagha Could you please help review the VM repair related PR?

Copy link
Member

@haagha haagha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update version number and version history if you want these changes to be published immediately. I don't think a test is required for this PR. Thanks!

@haagha haagha closed this Oct 23, 2023
@haagha haagha reopened this Oct 23, 2023
@qwuae1
Copy link
Contributor Author

qwuae1 commented Oct 24, 2023

@zhoxing-ms
Comments got addressed and approved by Haider.
but seems pr still blocked
Can you take a look and approve it?

@zhoxing-ms zhoxing-ms merged commit 87bb99e into Azure:main Oct 25, 2023
14 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=99579&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants