Use default_factory when a dataclass default is hashable (Python 3.11 compatibility) #6900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add temporary build workflow for AOSM extension * Add Releaser to maintain a release with the latest build in a consistent place
…extensions into jl/add-cnf-generation
Add empty init files to inner modules so setuptools recognises them
Use latest RG model to remove unnecessary dependency on version
Use latest Deployment model to remove unnecessary dependency on version
…extensions into jl/add-cnf-generation
…extensions into jl/add-cnf-generation
Update readme with install/bug reporting instructions
Add CNF NFD generation to build command
* Validation requirements on helm names * lint * markups * lint
Fix error parsing
* Lower case ACR names and fix interactive mode for lists * lint * remove duplicate else branch
Markups from the CLI team
Image value mappings fixes
* Regen Python SDK from 2023-09-01 API - also uses latest AutoRest client - fix for HybridNetworkManagementClient init signature (swap order of subscription_id and credential parameters) * Update CLI extension code to use new SDK * added SAMI to publisher pre deploy * Update bicep templates to use 2023-09-01 * Update NF templates * Update metaschema * Add Allow-Publisher to required feature flags * Use secure objects for deployment parameters
Correctly get array item types in CNF deployment parameter schemas
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
* moved blob url to vhd config only; untested * stopped error in post innit before validate * changed ordering of inputs so that blob and filepath are next to each other; helptext for filepath different for each option * Markups from sunny * appease mypy --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Sunny Carter <sunny.carter@metaswitch.com>
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @Cyclam, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.11 dataclasses require hashable defaults to use a default_factory.
This PR implements that for the az aosm extension.
Fixes #6426 (comment)
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aosm nfd generate-config --definition-type cnf
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.