AKS: Fix scenarios around nodepool and storagepool name for Azure Container Storage #6911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukhoakash
requested review from
andyliuliming and
FumingZhang
as code owners
️✔️Azure CLI Extensions Breaking Change Test
|
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
mukhoakash
force-pushed
the
storagepool_name_fix
branch
from
f044803
to
5f1b99d
Compare
|
please add test for the changes |
mukhoakash
force-pushed
the
storagepool_name_fix
branch
from
e59c31a
to
6427afd
Compare
mukhoakash
force-pushed
the
storagepool_name_fix
branch
from
6427afd
to
820ddf7
Compare
This reverts commit 820ddf7.
Live test added. It ran successfully https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=81953777&view=logs&j=b162b355-d59d-5864-ce0f-0a70f12dd28b&t=a26fe913-e2be-5062-b08e-d15f1acc7ea2 |
FumingZhang
reviewed
Oct 27, 2023
FumingZhang
reviewed
Oct 27, 2023
zhoxing-ms
reviewed
Oct 27, 2023
mukhoakash
force-pushed
the
storagepool_name_fix
branch
from
c76e56a
to
0a1cdd1
Compare
zhoxing-ms
approved these changes
Oct 28, 2023
…ragepool_name_fix
mukhoakash
force-pushed
the
storagepool_name_fix
branch
from
d46393d
to
a8b6366
Compare
mukhoakash
force-pushed
the
storagepool_name_fix
branch
2 times, most recently
from
316d84b
to
1e5ad09
Compare
mukhoakash
force-pushed
the
storagepool_name_fix
branch
from
1e5ad09
to
b20fcf2
Compare
mukhoakash
changed the title
mukhoakash
force-pushed
the
storagepool_name_fix
branch
from
672c000
to
bcdad06
Compare
zhoxing-ms
approved these changes
Oct 30, 2023
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=100804&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.