Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add endpoint-id to az monitor data-collection rule association #6921

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

AllyW
Copy link
Member

@AllyW AllyW commented Oct 30, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az monitor data-collection rule association

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.
closed Azure/azure-cli#26628

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 30, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️monitor-control-service
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd monitor data-collection rule association create cmd monitor data-collection rule association create added parameter endpoint_id
⚠️ 1006 - ParaAdd monitor data-collection rule association update cmd monitor data-collection rule association update added parameter endpoint_id

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 30, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@AllyW AllyW force-pushed the add-data-collection-associ-to-endpoint branch from bd2d44e to 10a9f31 Compare November 1, 2023 07:56
@AllyW AllyW merged commit 8c7ac33 into Azure:main Nov 1, 2023
14 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Nov 1, 2023

[Release] Update index.json for extension [ monitor-control-service ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=101824&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

associate resources to data collection endpoint
4 participants