Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI} Modify the extension's azdev test to use the azext_xxx directory #6933

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

wangzelin007
Copy link
Member

Modify the extension's azdev test to use the azext_xxx directory to avoid the issue of being unable to detect the test when it has the same name as the main module.
The containerapp module exists in both the main repo and the extension repo.
After installing the extension, running azdev test containerapp will not run any tests. The log is as follows:
image
To avoid this problem, modify the azdev test $extension command to the azdev test azext_$extension command.

Test screenshot:
image
image


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Hi @wangzelin007,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

azure-client-tools-bot-prd bot commented Nov 1, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 1, 2023

CI

@wangzelin007 wangzelin007 merged commit d8999f5 into Azure:main Nov 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants