Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[containerapp]
az containerapp create/update
: Support --customized-keys and clientType in --bind for dev service #6939[containerapp]
az containerapp create/update
: Support --customized-keys and clientType in --bind for dev service #6939Changes from 14 commits
ae8860e
4626893
6a8fb7b
b6f3ebf
cbb40e7
aedbcb9
592ce76
0f43bc2
b173a18
84e3b39
d7eee6b
cdfbc67
82e3796
e9c09d1
d2794a8
6d8fe37
1570179
69689e6
2c06fe8
dbc7040
99a1d3c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it is called by update command? If yes, when --client-type not provided, will it is cleared
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, for update command, we get the value from existing containerapp first, if the input
![image](https://private-user-images.githubusercontent.com/46143499/281996275-8e683480-579c-4090-83da-f484697ca41d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA5NDI0NzksIm5iZiI6MTcyMDk0MjE3OSwicGF0aCI6Ii80NjE0MzQ5OS8yODE5OTYyNzUtOGU2ODM0ODAtNTc5Yy00MDkwLTgzZGEtZjQ4NDY5N2NhNDFkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE0VDA3MjkzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFjYjBlOWQ3YWZmOTgzMGRjMzdlNWRkNTBmZWJjZjlkMGY4M2U3ODZkNWM4ZjJhYjUyOThlZGQ1ZTJhYzdhMmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.sB_ozDkq1cWrwyzVW2Y4z8Dh_zcgYmrS0NPtyGEl5Uc)
clientType
not exists, we will not set the value requestBody.We have test for
test update customizedKeys without clientType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you support update with --yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we support.