-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[containerapp] az containerapp add-on create: Support add-on commands; deprecation of service commands #6960
[containerapp] az containerapp add-on create: Support add-on commands; deprecation of service commands #6960
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
containerapp add-on | sub group containerapp add-on added |
Hi @bgashirabake, |
Hi @bgashirabake, |
containerapp |
Thank you for your contribution bgashirabake! We will review the pull request and get back to you soon. |
Please not mark test to
|
src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py
Outdated
Show resolved
Hide resolved
yea the cli-repo re-setup was a blindspot. synced and all's back to recording state! |
ready for review cc: @tawalke @Greedygre @yanzhudd . thank you all!! |
ADDON_LIST = ["redis", "postgres", "kafka", "mariadb", "qdrant"] | ||
create_containerapp_env(self, env_name, resource_group) | ||
|
||
self.cmd('containerapp addon redis create -g {} -n {} --environment {}'.format( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the provisiongState
for result. Same as blow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the provisioningState of all addons is checked in the for loop
@Juliehzl Could you help to review this PR? |
85127b1
to
2f4d7f1
Compare
g.custom_command('list', 'list_all_services') | ||
|
||
with self.command_group('containerapp service redis') as g: | ||
with self.command_group('containerapp addon', is_preview=True) as g: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what using containerapp add-on
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, i don't get your question...help explain more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but by the section that you commented on, the addon command group is the equivalent of the service one that's right above it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question is should we use az containerapp add-on
instead of using az containerapp addon
? @bgashirabake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh got it got it. in discussions with @SimonJakesch, addon was what was decided on, but i just checked the docs and add-on is what's being referenced. i can push the change for add-on in the morning but if release time is before then, i say we go with addon. the change is straight-forward so should be seamless if made in time
Hi @zhoxing-ms Could you please help to review this PR? Thanks. |
+ |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.