Fix param name fix for disk override

[nascarsayan]

Changes:

• Fix docs and help for vm creation from template with disk override.
• Convert any HCRP machine with empty kind to VMWare / AVS kind, while enabling vm from inventory.
• Password Reprompt fix for vcenter connect

---

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

[azure-client-tools-bot-prd]

️✔️Azure CLI Extensions Breaking Change Test

️✔️Non Breaking Changes

[azure-client-tools-bot-prd]

Hi @nascarsayan,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

[yonzhan]

Thank you for your contribution! We will review the pull request and get back to you soon.

[yanzhudd]

please add test for the changes.

[yanzhudd]

Since Azure CLI team is only responsible for the code style and specifications but not the business logic, it is better to involve the relevant service team in reviewing the business logic for this PR as well.

[nascarsayan]

please add test for the changes.

The changes are quite small and covers edge cases.

• Fix docs and help for vm creation from template with disk override.
  This is change for --help, and there is no testable code here.
• Convert any HCRP machine with empty kind to VMWare / AVS kind, while enabling vm from inventory.
  This is an edge case, where requiring agent install from an existing VM in onprem. Having a machine ready, and using that machine everytime for running UTs will be difficult (a manual step outside tests need to performed). We already have the test cases covering create machine + create VMInstance, where we create and delete all the resources.
• Password Reprompt fix for vcenter connect
  This is a reprompt for the user, we are reprompting for empty value as password.

[yanzhudd]

please add test for the changes.

The changes are quite small and covers edge cases.

• Fix docs and help for vm creation from template with disk override.
  This is change for --help, and there is no testable code here.
• Convert any HCRP machine with empty kind to VMWare / AVS kind, while enabling vm from inventory.
  This is an edge case, where requiring agent install from an existing VM in onprem. Having a machine ready, and using that machine everytime for running UTs will be difficult (a manual step outside tests need to performed). We already have the test cases covering create machine + create VMInstance, where we create and delete all the resources.
• Password Reprompt fix for vcenter connect
  This is a reprompt for the user, we are reprompting for empty value as password.

okay, how about rerunning the related test in live mode? Just make sure this change would not affect other normal logic.

[subbartt]

Since Azure CLI team is only responsible for the code style and specifications but not the business logic, it is better to involve the relevant service team in reviewing the business logic for this PR as well.

LGTM, for some some reason I was not able to review, are there any groups I need to join?

[nascarsayan]

please add test for the changes.

The changes are quite small and covers edge cases.

• Fix docs and help for vm creation from template with disk override.
  This is change for --help, and there is no testable code here.
• Convert any HCRP machine with empty kind to VMWare / AVS kind, while enabling vm from inventory.
  This is an edge case, where requiring agent install from an existing VM in onprem. Having a machine ready, and using that machine everytime for running UTs will be difficult (a manual step outside tests need to performed). We already have the test cases covering create machine + create VMInstance, where we create and delete all the resources.
• Password Reprompt fix for vcenter connect
  This is a reprompt for the user, we are reprompting for empty value as password.

okay, how about rerunning the related test in live mode? Just make sure this change would not affect other normal logic.

Have re-run the tests in live mode. One of our hosts got moved, so had to change the inventory ID of the Host we use in our tests.

[azclibot]

[Release] Update index.json for extension [ connectedvmware ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=109664&view=results