fix: datafactory data-flow update does not work

[JessicaLHartog]

az datafactory data-flow update is broken and cannot be used. There is a bug where data_flow_data["properties"]["typeProperties"] is not initialized to an empty dictionary and so every time the command is run, the following will appear at the end of the error trace:

in datafactory_data_flow_update
    data_flow_data["properties"]["typeProperties"]["sinks"] = properties[
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
KeyError: 'typeProperties'

To fix this issue (and prevent it from happening again) I've performed some refactoring to:

• DRY the code
• Eliminate some magic strings
• Increase readability by constructing inner dictionaries before nesting them

I based the expected behavior on the CLI documentation - specifically with respect to the following:

typeProperties: (optional) If none provided, a generic and empty definition is created. Including the definitions is best done by copying the JSON from within the Data Factory Studio in the Azure Portal.

---

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az datafactory data-flow create
az datafactory data-flow update

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

[azure-client-tools-bot-prd]

️✔️Azure CLI Extensions Breaking Change Test

️✔️Non Breaking Changes

[azure-client-tools-bot-prd]

Hi @JessicaLHartog,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

[yonzhan]

Thank you for your contribution! We will review the pull request and get back to you soon.

[JessicaLHartog]

@microsoft-github-policy-service agree company="Delphix"

[JessicaLHartog]

@evelyn-ys Any timeline where this can get looked at? The az datafactory data-flow update command does not work at all, so this fix is pretty important.