Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{CI} Add build wheel check and extension name check #7131

Merged
merged 9 commits into from
Dec 28, 2023
Merged

{CI} Add build wheel check and extension name check #7131

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
db1bab1
Update azdev_linter_style.py
wangzelin007 Dec 28, 2023
9d522d1
Merge branch 'main' into test_index_20231228
wangzelin007 Dec 28, 2023
6f48d19
Update setup.py
wangzelin007 Dec 28, 2023
0f651a6
Update azdev_linter_style.py
wangzelin007 Dec 28, 2023
8bca248
Update azdev_linter_style.py
wangzelin007 Dec 28, 2023
06c332a
Update azdev_linter_style.py
wangzelin007 Dec 28, 2023
4ed8806
Update azdev_linter_style.py
wangzelin007 Dec 28, 2023
d324ee4
Update setup.py
wangzelin007 Dec 28, 2023
5f9743a
Update azdev_linter_style.py
wangzelin007 Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions scripts/ci/azdev_linter_style.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,14 @@
import json
import logging
import os
import shutil
from subprocess import check_call, check_output, CalledProcessError

import service_name
from pkg_resources import parse_version

import service_name
from util import get_ext_metadata

logger = logging.getLogger(__name__)
logger.setLevel(logging.DEBUG)
ch = logging.StreamHandler()
Expand Down Expand Up @@ -87,7 +90,28 @@ def style(self):
self._cmd('azdev style {}'.format(self.extension_name))

def build(self):
pass
self._cmd('azdev extension build {}'.format(self.extension_name))

def check_extension_name(self):
original_cwd = os.getcwd()
dist_dir = os.path.join(original_cwd, 'dist')
files = os.listdir(dist_dir)
logger.info(f"wheel files in the dist directory: {files}")
logger.info(f"extension name is: {self.extension_name}")
for f in files:
if f.endswith('.whl'):
ext_file = os.path.join(dist_dir, f)
break
metadata = get_ext_metadata(dist_dir, ext_file, self.extension_name)
logger.info(f"metadata name in setup.py is: {metadata['name']}")
shutil.rmtree(dist_dir)
if '_' in self.extension_name:
raise ValueError(f"Underscores `_` are not allowed in the extension root directory, "
f"please change it to a hyphen `-`.")
if metadata['name'] != self.extension_name:
raise ValueError(f"The name {metadata['name']} in setup.py "
f"is not the same as the extension name {self.extension_name}! \n"
f"Please fix the name in setup.py!")


def find_modified_files_against_master_branch():
Expand Down Expand Up @@ -200,6 +224,8 @@ def azdev_on_internal_extension(modified_files, azdev_type):
azdev_extension.add_from_code()
if azdev_type in ['all', 'linter']:
azdev_extension.linter()
azdev_extension.build()
azdev_extension.check_extension_name()
if azdev_type in ['all', 'style']:
try:
azdev_extension.style()
Expand Down