Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logic] az logic workflow: Fix the issue with parameters in --definition not working #7132

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

Jing-song
Copy link
Contributor

@Jing-song Jing-song commented Dec 28, 2023


Fix the issue with parameters in --definition not working
close Azure/azure-cli#27982
aaz model Azure/aaz#379

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az logic workflow

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Dec 28, 2023

❌Azure CLI Extensions Breaking Change Test
❌logic
rule cmd_name rule_message suggest_message
1009 - ParaPropRemove logic workflow create cmd logic workflow create update parameter definition: removed property nargs=? please add back property nargs=? for parameter definition of cmd logic workflow create
1009 - ParaPropRemove logic workflow update cmd logic workflow update update parameter definition: removed property nargs=? please add back property nargs=? for parameter definition of cmd logic workflow update

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 28, 2023

Logic

@jsntcy
Copy link
Member

jsntcy commented Dec 28, 2023

❌Azure CLI Extensions Breaking Change Test

❌logic

rule
cmd_name
rule_message
suggest_message

1009 - ParaPropRemove
logic workflow create
cmd logic workflow create update parameter definition: removed property nargs=?
please add back property nargs=? for parameter definition of cmd logic workflow create

1009 - ParaPropRemove
logic workflow update
cmd logic workflow update update parameter definition: removed property nargs=?
please add back property nargs=? for parameter definition of cmd logic workflow update

@Jing-song, are these breaking changes expected?

@Jing-song
Copy link
Contributor Author

❌Azure CLI Extensions Breaking Change Test

❌logic
rule
cmd_name
rule_message
suggest_message
1009 - ParaPropRemove
logic workflow create
cmd logic workflow create update parameter definition: removed property nargs=?
please add back property nargs=? for parameter definition of cmd logic workflow create
1009 - ParaPropRemove
logic workflow update
cmd logic workflow update update parameter definition: removed property nargs=?
please add back property nargs=? for parameter definition of cmd logic workflow update

@Jing-song, are these breaking changes expected?

Yes, these are generated by codegen

@jsntcy jsntcy merged commit 23f6a14 into Azure:main Dec 28, 2023
16 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ logic ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=118481&view=results

ddouglas-msft pushed a commit to ddouglas-msft/azure-cli-extensions that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

az logic workflow create cmd does not pass in the parameters from the workflowdefinition.json Definition File
4 participants