[containerapp] az containerapp add-on create: Support for milvus add-on #7196
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp add-on milvus | sub group containerapp add-on milvus added |
|
Hi @bgashirabake, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
yonzhan,
wangzelin007,
yanzhudd,
zhoxing-ms,
jsntcy,
ruslany,
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek,
torosent,
pagariyaalok,
Juliehzl,
jijohn14 and
Greedygre
microsoft-github-policy-service
bot
added
the
customer-reported
|
Thank you for your contribution bgashirabake! We will review the pull request and get back to you soon. |
bgashirabake
changed the title
| g.custom_command('create', 'create_redis_service', supports_no_wait=True) | ||
| g.custom_command('delete', 'delete_redis_service', confirmation=True, supports_no_wait=True) | ||
|
|
||
| with self.command_group('containerapp add-on redis') as g: | ||
| g.custom_command('create', 'create_redis_service', supports_no_wait=True) | ||
| g.custom_command('delete', 'delete_redis_service', confirmation=True, supports_no_wait=True) | ||
|
|
||
| with self.command_group('containerapp service postgres', deprecate_info=self.deprecate(redirect='containerapp add-on postgres', expiration='2.56.1', hide=True)) as g: | ||
| with self.command_group('containerapp service postgres', deprecate_info=self.deprecate(redirect='containerapp add-on postgres', expiration='2.57.0', hide=True)) as g: |
There was a problem hiding this comment.
Hi @bgashirabake Which version of azure-cli is the expectation of last version that can uses az containerapp service?
As long as the expectation is that 2.56.0 is the last usable version, then there is no problem filling in 2.56.1.
There was a problem hiding this comment.
gotcha. it was a lil up in the air over what specific version we should make the cutoff...the very first cli release or the release right after our add-ons are added. since all add-ons can make it in 2.56.1, then i'll revert the cut-off to 2.56.1. thanks!
|
Please get approval from your team who could be responsible for your business logic. Thanks. |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.