[Containerapp] az containerapp env telemetry: add command for updating telemetry settings #7199

michaelkira · 2024-01-19T03:58:19Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-01-19T03:58:22Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️containerapp

rule cmd_name rule_message suggest_message

⚠️ 1011 - SubgroupAdd containerapp env telemetry sub group containerapp env telemetry added

azure-client-tools-bot-prd · 2024-01-19T03:58:25Z

Hi @michaelkira,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2024-01-19T03:58:32Z

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan · 2024-01-24T08:32:03Z

Please fix CI issues.

src/containerapp/azext_containerapp/containerapp_env_telemetry_decorator.py

src/containerapp/azext_containerapp/custom.py

Greedygre

Please resolve the conflict and add two blank lines between functions.

Juliehzl · 2024-03-01T02:25:04Z

src/containerapp/azext_containerapp/_help.py

+
+# Container Apps Telemetry Commands
+
+helps['containerapp env telemetry data-dog set'] = """


add help information for 'containerapp env telemetry'

Juliehzl · 2024-03-01T02:26:52Z

src/containerapp/azext_containerapp/commands.py

+
+    with self.command_group('containerapp env telemetry data-dog', is_preview=True) as g:
+        g.custom_command('set', 'set_environment_telemetry_data_dog', supports_no_wait=True, exception_handler=ex_handler_factory())
+        g.custom_command('delete', 'delete_environment_telemetry_data_dog', supports_no_wait=True, exception_handler=ex_handler_factory())


confirmation

Juliehzl · 2024-03-01T02:28:17Z

src/containerapp/azext_containerapp/containerapp_env_telemetry_decorator.py

+        return self.get_param("enable_open_telemetry_metrics")
+
+    def construct_payload(self):
+        # Get containerapp env properties of CA we are updating


what does CA mean?

Juliehzl · 2024-03-01T02:33:38Z

src/containerapp/azext_containerapp/containerapp_env_telemetry_decorator.py

+                safe_set(self.managed_env_def, "properties", "openTelemetryConfiguration", "tracesConfiguration", "destinations", value=existing_traces)
+            elif not self.get_argument_enable_open_telemetry_traces() and DATA_DOG_DEST in existing_traces:
+                existing_traces.remove(DATA_DOG_DEST)
+                safe_set(self.managed_env_def, "properties", "openTelemetryConfiguration", "tracesConfiguration", "destinations", value=existing_traces)


duplicated code with L63 and L67. could we set it outside if

src/containerapp/azext_containerapp/containerapp_env_telemetry_decorator.py

src/containerapp/azext_containerapp/custom.py

src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_telemetry.py

Greedygre · 2024-03-04T02:22:26Z

src/containerapp/HISTORY.rst

+* 'az containerapp env telemetry data-dog set': support update environment data dog configuration with --site, --key, --enable-open-telemetry-traces and --enable-open-telemetry-metrics
+* 'az containerapp env telemetry data-dog delete': support delete environment data dog configuration
+* 'az containerapp env telemetry app-insights set': support update environment app insights configuration with --connection-string, --enable-open-telemetry-traces and --enable-open-telemetry-logs
+* 'az containerapp env telemetry app-insights delete': support delete environment app insights configuration


Please move to the history.rst

src/containerapp/azext_containerapp/containerapp_env_telemetry_decorator.py

Juliehzl · 2024-03-05T03:13:41Z

src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_telemetry.py

+            time.sleep(5)
+            containerapp_env = self.cmd('containerapp env show -g {} -n {}'.format(resource_group, env_name)).get_output_in_json()
+
+        self.cmd('containerapp env show -n {} -g {}'.format(env_name, resource_group), checks=[


recommend to delete env in the end of test

michaelkira added 2 commits January 19, 2024 10:59

update

d4a94cc

update

b918ed4

azure-client-tools-bot-prd bot added this to the January 2024 (2024-02-06) milestone Jan 19, 2024

yonzhan requested review from yanzhudd and zhoxing-ms January 19, 2024 04:35

yonzhan assigned zhoxing-ms Jan 19, 2024

michaelkira added 7 commits January 22, 2024 11:26

remove include-system-telemetry

5500bc5

update

df2e21f

update

e28d896

update test

6268d7c

update

2c695cc

update

d04b740

update

ad09e27

michaelkira marked this pull request as ready for review January 24, 2024 06:48

michaelkira changed the title ~~Add otel commands~~ Add containerapp env telemetry preview Jan 24, 2024

update

8b5cdcb

update

172e62b

michaelkira changed the title ~~Add containerapp env telemetry preview~~ [Containerapp] az containerapp env telemetry: add command for telemetry settings Jan 24, 2024

michaelkira changed the title ~~[Containerapp] az containerapp env telemetry: add command for telemetry settings~~ [Containerapp] az containerapp env telemetry: add command for updating telemetry settings Jan 24, 2024

update

8bf599a

Greedygre reviewed Jan 25, 2024

View reviewed changes

src/containerapp/azext_containerapp/containerapp_env_telemetry_decorator.py Outdated Show resolved Hide resolved

Greedygre reviewed Jan 25, 2024

View reviewed changes

src/containerapp/azext_containerapp/containerapp_env_telemetry_decorator.py Outdated Show resolved Hide resolved

Greedygre reviewed Jan 25, 2024

View reviewed changes

src/containerapp/azext_containerapp/custom.py Outdated Show resolved Hide resolved

michaelkira added 3 commits January 25, 2024 12:29

update

f7b8cf3

Merge branch 'main' into private/michdai/addotelcommands

2d35de5

update

4c7370e

michaelkira added 2 commits February 29, 2024 15:35

update

69dfe2e

udpate

2dad758

Greedygre approved these changes Feb 29, 2024

View reviewed changes

update

5164b3e

Greedygre approved these changes Feb 29, 2024

View reviewed changes

Juliehzl reviewed Mar 1, 2024

View reviewed changes

src/containerapp/azext_containerapp/containerapp_env_telemetry_decorator.py Outdated Show resolved Hide resolved

Juliehzl reviewed Mar 1, 2024

View reviewed changes

src/containerapp/azext_containerapp/containerapp_env_telemetry_decorator.py Outdated Show resolved Hide resolved

Juliehzl reviewed Mar 1, 2024

View reviewed changes

src/containerapp/azext_containerapp/containerapp_env_telemetry_decorator.py Outdated Show resolved Hide resolved

Juliehzl reviewed Mar 1, 2024

View reviewed changes

src/containerapp/azext_containerapp/custom.py Outdated Show resolved Hide resolved

Juliehzl reviewed Mar 1, 2024

View reviewed changes

src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_telemetry.py Show resolved Hide resolved

michaelkira added 4 commits March 1, 2024 14:37

update

6f4013c

update

7ffd05f

update

ec13c3a

update

ec7ac11

Greedygre reviewed Mar 4, 2024

View reviewed changes

Juliehzl reviewed Mar 4, 2024

View reviewed changes

src/containerapp/azext_containerapp/containerapp_env_telemetry_decorator.py Show resolved Hide resolved

Juliehzl reviewed Mar 4, 2024

View reviewed changes

src/containerapp/azext_containerapp/containerapp_env_telemetry_decorator.py Show resolved Hide resolved

michaelkira added 4 commits March 5, 2024 10:14

Merge branch 'main' into private/michdai/addotelcommands

ce60dc4

update

bbe89ad

update

8b4c8e8

update

a22a764

Greedygre approved these changes Mar 5, 2024

View reviewed changes

Juliehzl reviewed Mar 5, 2024

View reviewed changes

Juliehzl approved these changes Mar 5, 2024

View reviewed changes

yanzhudd approved these changes Mar 5, 2024

View reviewed changes

yanzhudd merged commit 8ea2cc2 into Azure:main Mar 5, 2024
14 of 15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Containerapp] az containerapp env telemetry: add command for updating telemetry settings #7199

[Containerapp] az containerapp env telemetry: add command for updating telemetry settings #7199

michaelkira commented Jan 19, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Jan 19, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Jan 19, 2024

yonzhan commented Jan 19, 2024

yonzhan commented Jan 24, 2024

Greedygre left a comment

Juliehzl Mar 1, 2024

Juliehzl Mar 1, 2024

Juliehzl Mar 1, 2024

Juliehzl Mar 1, 2024 •

edited

Loading

Greedygre Mar 4, 2024

Juliehzl Mar 5, 2024


		# Container Apps Telemetry Commands

		helps['containerapp env telemetry data-dog set'] = """

[Containerapp] az containerapp env telemetry: add command for updating telemetry settings #7199

[Containerapp] az containerapp env telemetry: add command for updating telemetry settings #7199

Conversation

michaelkira commented Jan 19, 2024 • edited Loading

Related command

General Guidelines

About Extension Publish

azure-client-tools-bot-prd bot commented Jan 19, 2024 • edited Loading

azure-client-tools-bot-prd bot commented Jan 19, 2024

yonzhan commented Jan 19, 2024

yonzhan commented Jan 24, 2024

Greedygre left a comment

Choose a reason for hiding this comment

Juliehzl Mar 1, 2024

Choose a reason for hiding this comment

Juliehzl Mar 1, 2024

Choose a reason for hiding this comment

Juliehzl Mar 1, 2024

Choose a reason for hiding this comment

Juliehzl Mar 1, 2024 • edited Loading

Choose a reason for hiding this comment

Greedygre Mar 4, 2024

Choose a reason for hiding this comment

Juliehzl Mar 5, 2024

Choose a reason for hiding this comment

michaelkira commented Jan 19, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Jan 19, 2024 •

edited

Loading

Juliehzl Mar 1, 2024 •

edited

Loading