Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support certificate from keyvault #7259

Merged
merged 9 commits into from
Mar 6, 2024

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Feb 6, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Feb 6, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd containerapp env certificate upload cmd containerapp env certificate upload added parameter certificate_identity
⚠️ 1006 - ParaAdd containerapp env certificate upload cmd containerapp env certificate upload added parameter certificate_key_vault_url
⚠️ 1009 - ParaPropRemove containerapp env certificate upload cmd containerapp env certificate upload update parameter certificate_file: removed property required=True
⚠️ 1006 - ParaAdd containerapp env create cmd containerapp env create added parameter certificate_identity
⚠️ 1006 - ParaAdd containerapp env create cmd containerapp env create added parameter certificate_key_vault_url
⚠️ 1006 - ParaAdd containerapp env update cmd containerapp env update added parameter certificate_identity
⚠️ 1006 - ParaAdd containerapp env update cmd containerapp env update added parameter certificate_key_vault_url

Copy link

Hi @njuCZ,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 6, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@njuCZ njuCZ force-pushed the user/njucz/support_cert_msi branch 2 times, most recently from 260e8c8 to 29f9526 Compare February 28, 2024 08:57

if self.get_argument_mtls_enabled() is not None:
safe_set(self.managed_env_def, "properties", "peerAuthentication", "mtls", "enabled", value=self.get_argument_mtls_enabled())
### copy end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not call parent construct_payload directly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njuCZ njuCZ force-pushed the user/njucz/support_cert_msi branch from 6a957b8 to cd32b10 Compare February 29, 2024 06:46
@Greedygre
Copy link
Contributor

@njuCZ
Please fix the linter error as following:

-  FAIL - HIGH severity: option_length_too_long
    Parameter: containerapp env create, `certificate_key_vault_url` - The lengths of all options ['--custom-domain-certificate-key-vault-url', '--certificate-key-vault-url'] are longer than threshold 22. Argument certificate_key_vault_url must have a short abbreviation.
    Parameter: containerapp env update, `certificate_key_vault_url` - The lengths of all options ['--custom-domain-certificate-key-vault-url', '--certificate-key-vault-url'] are longer than threshold 22. Argument certificate_key_vault_url must have a short abbreviation.

@njuCZ njuCZ force-pushed the user/njucz/support_cert_msi branch from f0c5b43 to 20ac6ae Compare March 6, 2024 00:38
@yanzhudd yanzhudd merged commit c4baba3 into Azure:main Mar 6, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants