-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support certificate from keyvault #7259
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
containerapp env certificate upload | cmd containerapp env certificate upload added parameter certificate_identity |
||
containerapp env certificate upload | cmd containerapp env certificate upload added parameter certificate_key_vault_url |
||
containerapp env certificate upload | cmd containerapp env certificate upload update parameter certificate_file : removed property required=True |
||
containerapp env create | cmd containerapp env create added parameter certificate_identity |
||
containerapp env create | cmd containerapp env create added parameter certificate_key_vault_url |
||
containerapp env update | cmd containerapp env update added parameter certificate_identity |
||
containerapp env update | cmd containerapp env update added parameter certificate_key_vault_url |
Hi @njuCZ, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py
Outdated
Show resolved
Hide resolved
260e8c8
to
29f9526
Compare
src/containerapp/azext_containerapp/containerapp_env_certificate_decorator.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/containerapp_env_certificate_decorator.py
Show resolved
Hide resolved
src/containerapp/azext_containerapp/containerapp_env_certificate_decorator.py
Show resolved
Hide resolved
|
||
if self.get_argument_mtls_enabled() is not None: | ||
safe_set(self.managed_env_def, "properties", "peerAuthentication", "mtls", "enabled", value=self.get_argument_mtls_enabled()) | ||
### copy end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not call parent construct_payload directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because it hardcode the custom domain logic, we could use this logic
src/containerapp/azext_containerapp/containerapp_env_decorator.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/containerapp_env_decorator.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py
Outdated
Show resolved
Hide resolved
6a957b8
to
cd32b10
Compare
@njuCZ
|
f0c5b43
to
20ac6ae
Compare
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.